Skip to content

fix(compile): use BTreeMap order for tagged alternation variant indices #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zharinov merged 1 commit into from
Jan 4, 2026
Merged

fix(compile): use BTreeMap order for tagged alternation variant indices #235

zharinov merged 1 commit into from
Jan 4, 2026

Conversation

@zharinov
Copy link
Member

@zharinov zharinov commented Jan 4, 2026

Summary

  • Fixed tagged alternation variant index ordering to use BTreeMap (Symbol) order instead of AST iteration order
  • This fixes a bug where variant indices could be wrong when a named definition is parsed before the alternation (changing Symbol interning order)

Test

Added alternation_tagged_definition_ref_backtrack test case that reproduces the issue.

@zharinov zharinov enabled auto-merge (squash) January 4, 2026 01:20
@zharinov zharinov merged commit 3daa56d into master Jan 4, 2026
4 checks passed
@zharinov zharinov deleted the fix/tagged-alt-variant-order branch January 4, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zharinov